[coreboot] [PATCH] Fix RS690 MMCONFIG access

Myles Watson mylesgw at gmail.com
Fri Mar 20 20:41:28 CET 2009

> -----Original Message-----
> From: Marc Jones [mailto:marcj303 at gmail.com]
> On Thu, Mar 19, 2009 at 4:32 AM, Myles Watson <mylesgw at gmail.com> wrote:
> > Here's my 2 cents:
> > 1. Overwrite read resources so it doesn't touch your MMConfig BAR
> > (sizing it would not be good)
> > 2. Overwrite set_resources so that it:
> >     a. disables MMConfig accesses
> >     b. writes the new value to the MMConfig BAR
> >     c. enables MMConfig accesses
> I assume you mean to change which ever 690 device operations struct
> it is. Then check the address for the bar and skip it if mmconfig
> otherwise do a normal read/write. That sounds good to me.

Thanks for clarifying.  It was a little early :)

Skip it for read_resources.  Disable, write, then enable using conf1 pci
config accesses for set_resources.  Otherwise use the default.

I think that will allow you to use mmconfig accesses everywhere else.


More information about the coreboot mailing list