[coreboot] [patch] k8 bga fid msr check bug

Ward Vandewege ward at gnu.org
Thu Mar 19 22:39:42 CET 2009


On Thu, Mar 19, 2009 at 03:36:39PM -0600, Marc Jones wrote:
> Signed-off-by: Marc Jones <marcj303 at gmail.com>

Boot tested on Supermicro H8DME.

Acked-by: Ward Vandewege <ward at gnu.org>

Thanks,
Ward.

> Fix CPUID typo. This caused fid to memory speed calculations to be off.
> 
> Signed-off-by: Marc Jones <marcj303 at gmail.com>
> 
> Index: coreboot-v2/src/northbridge/amd/amdk8/raminit_f.c
> ===================================================================
> --- coreboot-v2.orig/src/northbridge/amd/amdk8/raminit_f.c	2009-03-19 14:18:36.000000000 -0600
> +++ coreboot-v2/src/northbridge/amd/amdk8/raminit_f.c	2009-03-19 15:30:33.000000000 -0600
> @@ -1655,7 +1655,7 @@
>  
>  	/* Check for FID control support */
>  	struct cpuid_result cpuid1;
> -	cpuid1 = cpuid(0x8000007);
> +	cpuid1 = cpuid(0x80000007);
>  	if( cpuid1.edx & 0x02 ) {
>  		/* Use current FID */
>  		unsigned fid_cur;

> -- 
> coreboot mailing list: coreboot at coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot
> 
> !DSPAM:49c2bb13296901804284693!

-- 
First Annual Libre Planet on March 21/22 2009: http://fsf.org/conference
Ward Vandewege <ward at fsf.org>
Free Software Foundation - Senior Systems Administrator




More information about the coreboot mailing list