[coreboot] [PATCH] v3: Improve printk reliability

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Mar 19 13:55:41 CET 2009


On 19.03.2009 13:47, Peter Stuge wrote:
> Carl-Daniel Hailfinger wrote:
>   
>> I fully agree. I looked at the code repeatedly and I can't find a nice
>> and readable way to do it. Sure, there are hackish ways to achieve the
>> goal, but vtxprintf is already complicated enough to let me stop before
>> such a trick.
>> "<%03x near NULL>" would be an alternative with mostly readable code.
>>     
>
> I think this looks nice.
>
>   
>> The new message reads "<near NULL>".
>>     
>
> Ok. I'll look at adding the address in a separate patch.
>   

Thanks.


>> OK to commit?
>>     
>
> Go for it.
>   

Committed in r4020.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list