[coreboot] [PATCH] Fix RS690 MMCONFIG access

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Mar 18 12:43:58 CET 2009


On 18.03.2009 12:29, Peter Stuge wrote:
> Carl-Daniel Hailfinger wrote:
>   
>> 2. If the MMCONFIG area should be relocatable (possible on RS690),
>> make sure it gets special handling (disable directly before
>> relocation, reenable directly after relocation).
>>     
>
> I like this the best. Well done finding+fixing the bug!
>
> If you don't feel like taking this on at the moment maybe it's a good
> candidate for a ticket in trac,

I'm seriously time-contrained (max. coreboot time is a few minutes per
week) until April 7th due to university exams. Could you please open a
ticket or look otherwise into this?

> and the ugly workaround can be
> committed?
>
> Acked-by: Peter Stuge <peter at stuge.se>
>   

Thanks.
The workaround unfortunately pollutes every single x86 board in the tree
with RS690 specific code, so I'm hesitant to apply it. And I don't fully
understand the v2 device model, so I have no idea where to place the
correct fix.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list