[coreboot] [PATCH] v2 i945 updates

Peter Stuge peter at stuge.se
Wed Mar 11 17:44:35 CET 2009

Stefan Reinauer wrote:
> > Please PLEEASE do not include whitespace fixes in other patches!!
> >
> > That requires THREE or FOUR times the effort for every review - and
> > the result is that less people will bother to look at the code!
> Big sorry for that. early_init.c is a bit of a special case for me
> here, and I'm still practising to get it right.


> I'll try to do better the next time.

Awesome. The important thing to take away is not that I get upset
at whitespace changes, but that review quality suffers tremendously.

My mind becomes saturated so much more quickly when scrutinizing a
bunch of lines that didn't really change, compared to same number of
lines where there are actual changes.


More information about the coreboot mailing list