[coreboot] [PATCH] flashrom: Use helper functions to access flash chips

FENG Yu Ning fengyuning1984 at gmail.com
Thu Mar 5 15:45:05 CET 2009

Carl-Daniel Hailfinger wrote:

> This patch has the additional advantage of removing lots of unnecessary
> casts to volatile uint8_t * and now-superfluous parentheses which caused
> poor readability.

Generally, patched code looks much nicer. As a trade-off, some code loses
symmetry, e.g.

> -                       *dst = *src;
> +                       writeb(*src, dst);

> I used the semantic patcher Coccinelle to create this patch.

That is interesting. I have a new tool to learn.

The patch is

Acked-by: FENG Yu Ning <fengyuning1984 at gmail.com>

More information about the coreboot mailing list