[coreboot] ACPI patches for Tyan s2895, s2892, s2891

Myles Watson mylesgw at gmail.com
Wed Mar 4 18:09:27 CET 2009

I refactored the patches to simplify reviewing.  In a coming patch
there are some bugfixes in amdk8_util.asl, so this will help with

changes by file:
       Be Paranoid and set srat_lapic table to zero before filling it.
       Enable SLIT filling if acpi_create_slit gets called.

       Put this file here instead of every board having a personal copy.

       Put this file here instead of every board having a personal copy.

       Change the path to amd*_util.asl

       Add slit prototype and minor whitespace.

This patch is abuild tested.

Signed-off-by: Myles Watson <mylesgw at gmail.com>

>> I didn't see the deletion of the per-board copies. Did subversion forget
>> to include them in the diff?

I will follow the patch with

svn rm src/mainboard/iwill/dk8_htx/dx/amdk8_util.asl
svn rm src/mainboard/amd/serengeti_cheetah/dx/amdk8_util.asl
svn rm src/mainboard/amd/serengeti_cheetah_fam10/dx/amdfam10_util.asl
svn rm src/mainboard/asus/m2v-mx_se/amdk8_util.asl

>> Besides that, moving the related fam10 file as well would be nice.


>> Maybe
>> also a splitout of the K8 util ACPI code from the DBM690T and Pistachio
>> code, but that seems to be more work.

The ACPI code is totally different for those boards.  It doesn't even
use the same functions.  The util files for those boards could be
moved somewhere central, but I think it's best left for another patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: amdk8_util.diff
Type: text/x-patch
Size: 24797 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090304/81ecd318/attachment.diff>

More information about the coreboot mailing list