[coreboot] [PATCH 2/2] AMD boards to use new Power Now infrastructure

[Myles Watson]

On Mon, Mar 2, 2009 at 3:50 PM, Rudolf Marek <r.marek at assembler.cz> wrote:
> Myles Watson napsal(a):
>>
>> On Thu, Feb 19, 2009 at 1:39 AM, Rudolf Marek <r.marek at assembler.cz>
>> wrote:
>>>>
>>>> And your code shows one processor, the original code shows four
>>>> processors (I have one single-core CPU).
>>>
>>> I choose to generate the code just for cores which exists.
>>
>> I have two dual-core CPUs, and code is only generated for two of them.
>>  I see the for loop with write_pstates_for_core in powernow_acpi.c.
>> Should there be another loop for packages?
>
> Yes but it needs to read new data from the AP CPU (the MSRs and CPUIDs)
> Dont know if we have funcs like cpuid_on_cpu and msr_on_cpu.
>
>
>> I guess I'm not sure which
>> two cores are being found by your algorithm.
>
> Just BSP processor. It needs to be thought how to do that for more CPUs,
> perhaps using funcs like above.

I guess the alternative is to force users to use matched CPUs.  Do we
already force that for microcode patches?

Thanks,
Myles