[coreboot] patch tosuperiotool - add LPC47N252

[CybFr]

Le samedi 27 juin 2009 04:23:50, Uwe Hermann a écrit :
> On Fri, Jun 26, 2009 at 11:25:50PM +0200, CybFr wrote:
> > Signed-off-by: François-Regis Vuillemin <coreboot at miradou.com
>
> Thanks, committed in r4375.
>
> > +	{0x0e, "LPC47N252", {   /* From sensors-detect */
> > +		{NOLDN, NULL,
> > +			{0x02,0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x27,0x28,
> > +			 0x29,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT},
> > +			{0x00,0x0e,0x00,0x00,0x00,0x04,0x04,NANA,NANA,0x00,
> > +			 0x00,0x00,0x00,0x00,0x00,0x00,0x00,EOT}},
>
> I dropped 0x02, that's a write-only register.
>
> > +		{0x7, "Keyboard",
> > +			{0x30,0x60,0x61,0x70,0x72,0xf0,EOT},
> > +			{0x00,0x00,0x00,0x00,0x00,0x00,EOT}},
>
> Can you post a 'superiotool -d' output from your laptop please? The
> datasheet doesn't seem to mention 0x60/0x61 for this LDN (says the
> address is fixed and not relocatable). Not sure if we can/should dump
> 0x60/0x61 here.
>

You're right, see the file. 

Thanks for your help.
-- 
FR
-------------- next part --------------
superiotool r4356
Found SMSC LPC47N252 (id=0x0e, rev=0x01) at 0x2e
Register dump:
idx 02 20 21 22 23 24 25 26  27 28 29 2a 2b 2c 2d 2e  2f
val 00 0e 01 09 00 84 04 2e  00 00 00 00 00 00 00 00  00
def 00 0b 00 00 00 04 04 NA  NA 00 00 00 00 00 00 00  00
LDN 0x00 (Floppy)
idx 30 60 61 70 74 f0 f1 f2  f3 f4 f5
val 01 03 f0 06 02 9e 08 00  00 00 00
def 00 03 f0 06 02 0e 00 ff  RR 00 00
LDN 0x01 (Power Management (PM1))
idx 30 60 61
val 00 00 00
def 00 00 00
LDN 0x03 (Parallel port)
idx 30 60 61 70 74 f0 f1
val 01 00 00 00 04 3a 00
def 00 00 00 00 04 3c 00
LDN 0x04 (COM1)
idx 30 60 61 70 f0
val 00 00 00 00 00
def 00 00 00 00 00
LDN 0x05 (COM2)
idx 30 60 61 62 63 70 74 f0  f1 f2 f7 f8
val 00 00 00 00 00 00 04 00  02 03 00 00
def 00 00 00 00 00 00 04 00  02 03 00 00
LDN 0x06 (Real-time clock (RTC))
idx 30 60 61 62 63 70 f0 f1
val 00 00 70 00 74 00 00 00
def 00 00 70 00 74 00 00 NA
LDN 0x07 (Keyboard)
idx 30 60 61 70 72 f0
val 01 00 00 01 0c 00
def 00 00 00 00 00 00
LDN 0x08 (Embedded Controller (EC))
idx 30 60 61
val 00 00 62
def 00 00 62
LDN 0x09 (Mailbox)
idx 30 60 61
val 01 09 10
def 00 00 00
LDN 0x0a (LGPIO)
idx 30 60 61
val 01 09 00
def 00 00 00