[coreboot] [PATCH] flashrom: Check result of all SPI erase functions
Uwe Hermann
uwe at hermann-uwe.de
Wed Jun 24 00:00:19 CEST 2009
On Mon, Jun 22, 2009 at 11:57:03AM +0200, Carl-Daniel Hailfinger wrote:
> Check result of all SPI erase functions.
> Since block erase functions do not know the block length (it's not
> specified in any standard), block erase functions now get an additional
> parameter blocklen. This enables flashrom to verify the erase result for
> block erase functions at correct boundaries.
>
> Unchecked erase is bad and can lead to problems nobody can understand.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
Tested OK on an sb600 board.
> Index: flashrom-spi_verify_erase/spi.c
> ===================================================================
> --- flashrom-spi_verify_erase/spi.c (Revision 618)
> +++ flashrom-spi_verify_erase/spi.c (Arbeitskopie)
> @@ -1,7 +1,7 @@
> /*
> * This file is part of the flashrom project.
> *
> - * Copyright (C) 2007, 2008 Carl-Daniel Hailfinger
> + * Copyright (C) 2007, 2008, 2009 Carl-Daniel Hailfinger
Maybe 2007-2009 for brevity and shorter lines (on the long term).
Uwe.
--
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
More information about the coreboot
mailing list