[coreboot] [PATCH] flashrom: Clean up Makefile

Luc Verhaegen libv at skynet.be
Tue Jun 23 13:40:51 CEST 2009


On Tue, Jun 23, 2009 at 12:49:55PM +0200, Carl-Daniel Hailfinger wrote:
> The akefile rules for %.o and flashrom.o are identical. Let %.o handle
> flashrom.o as well.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> 
> Index: flashrom-makefile_cleanup/Makefile
> ===================================================================
> --- flashrom-makefile_cleanup/Makefile	(Revision 624)
> +++ flashrom-makefile_cleanup/Makefile	(Arbeitskopie)
> @@ -70,11 +70,8 @@
>  
>  FEATURE_LIBS = $(shell LANG=C grep -q "FTDISUPPORT := yes" .features && printf "%s" "-lftdi")
>  
> -flashrom.o: flashrom.c .features
> -	$(CC) $(CFLAGS) $(CPPFLAGS) $(FEATURE_CFLAGS) -c -o $@ $< $(SVNDEF)
> -
>  %.o: %.c .features
> -	$(CC) $(CFLAGS) $(CPPFLAGS) $(FEATURE_CFLAGS) -c $< -o $@ $(SVNDEF)
> +	$(CC) $(CFLAGS) $(CPPFLAGS) $(FEATURE_CFLAGS) $(SVNDEF) -o $@ -c $<
>  
>  clean:
>  	rm -f $(PROGRAM) *.o

Ah, more simple flashrom things that even i understand...

Acked-by: Luc Verhaegen <libv at skynet.be>

Why am i seeing your patches double in your emails? Np for small ones, 
but for a big patch, seeing it double might be confusing.

Luc Verhaegen.




More information about the coreboot mailing list