[coreboot] [PATCH] flashrom: SB600 SPI: Kill unused variable

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Jun 23 02:48:59 CEST 2009

On 23.06.2009 00:09, Luc Verhaegen wrote:
> On Mon, Jun 22, 2009 at 04:31:44PM +0200, Carl-Daniel Hailfinger wrote:
>> SB600 SPI: Kill unused variable.
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> If this builds, then what can be wrong with this :)
> I guess you are keeping this struct because publically available 
> documentation is perhaps not as clear as it should be?

Well, the documentation is pretty readable, but the struct is a handy
compressed reference and useful if you want to avoid reading dozens of
datasheet pages.

> Why not comment 
> it completely so that no-one else will complain about it in future?


> Please also make reset_internal_fifo_pointer and execute_command static 
> so thatthese symbols, when unused, will turn up in the build as well.


> Apart from that, of course:
> Acked-by: Luc Verhaegen <libv at skynet.be>

Thanks, committed in r623.



More information about the coreboot mailing list