[coreboot] [PATCH] remove namestring trickery

Harald Gutmann harald.gutmann at gmx.net
Sun Jun 21 22:20:40 CEST 2009


On Saturday 20 June 2009 15:36:13 Rudolf Marek wrote:
> Hello,
>
> The  namestring handling in ACPIgen was a big trickery. We were pasing the
> strings as it was a bytestream already. This was a reason for instead of
> _PR one had to write _PR_
>
> Or \_SB.PCI0 was in fact \_SB_PCI0.
>
> This patch adds a proper namestring generation to our ACPIgen generator.
> Its used for Name and Scope and Processor now. As bonus, it allows to
> create a multi name paths too. Like Scope(\ALL.YOUR.BASE).
>
> Signed-off-by: Rudolf Marek <r.marek at assembler.cz>
Acked-by: Harald Gutmann <harald.gutmann at gmx.net>

I didn't review the whole patch, but it seems to be fine.
The tests I did on hardware went all like they should.

> I have no board now, so I cannot test it on real HW. I did some tests which
> a ACPIgen testbench which I'm attaching for future reference.
I've tested this patch on M57SLI.
The SSDT.dsl tables from a plain cb-v2 rev. 4367 and the same rev. with this 
patch are attached.

PowerNow remains working, like it should, and there are no differences after 
patching cb in the SSDT.dsl tables.

> I dont know what happen to fam10 code, but I think it will need similar
> change.
>
> Rudolf
Regards,
Harald

-------------- next part --------------
A non-text attachment was scrubbed...
Name: SSDT_plain.dsl
Type: text/x-dsl
Size: 7775 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090621/fb6accbc/attachment.dsl>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SSDT_remove_namespace_string.dsl
Type: text/x-dsl
Size: 7775 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090621/fb6accbc/attachment-0001.dsl>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090621/fb6accbc/attachment.sig>


More information about the coreboot mailing list