[coreboot] [PATCH] flashrom: Kill obsolete exclude range feature

Uwe Hermann uwe at hermann-uwe.de
Fri Jun 19 13:17:37 CEST 2009


On Tue, Jun 16, 2009 at 02:10:56PM +0200, Carl-Daniel Hailfinger wrote:
> Kill obsolete exclude range feature. It is ignored by almost every chip
> and does not work for external flashers. Plus, it gives the user a false
> sense of security in some corner cases.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

 
> Index: flashrom-kill_exclude_range/flashrom.8
> ===================================================================
> --- flashrom-kill_exclude_range/flashrom.8	(Revision 597)
> +++ flashrom-kill_exclude_range/flashrom.8	(Arbeitskopie)
> @@ -50,9 +50,6 @@
>  .TP
>  .B "\-c, \-\-chip" <chipname>
>  Probe only for specified flash ROM chip.
> -.TP
> -.B "\-s, \-\-estart" <addr>
> -Exclude start position (obsolete).

Also kill it at the beginning of the manpage (SYNOPSIS).


>  	numbytes = fwrite(buf, 1, size, image);
>  	fclose(image);
>  	free(buf);
> @@ -581,8 +576,6 @@
>  	     "   -E | --erase:                     erase flash device\n"
>  	     "   -V | --verbose:                   more verbose output\n"
>  	     "   -c | --chip <chipname>:           probe only for specified flash chip\n"
> -	     "   -s | --estart <addr>:             exclude start position\n"
> -	     "   -e | --eend <addr>:               exclude end postion\n"

Same here, drop it from getopt_long() line.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list