[coreboot] [PATCH] flashrom: Partial read support

Uwe Hermann uwe at hermann-uwe.de
Tue Jun 16 02:23:50 CEST 2009


On Tue, Jun 16, 2009 at 01:14:38AM +0200, Carl-Daniel Hailfinger wrote:
> On 13.06.2009 16:27, Carl-Daniel Hailfinger wrote:
> > On 13.06.2009 01:48, Carl-Daniel Hailfinger wrote:
> >   
> >> With this patch it is possible to read arbitarary chip ranges on a byte
> >> boundary.
> >> That means you can tell flashrom to read exactly bytes 12345-56789
> >> (start 12345, length 44445) and it will not fetch a single byte more.
> >>
> >> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> >>   
> >>     
> >
> > Updated patch to apply against svn HEAD and fixed some SPI issues.
> >
> > This patch gives us arbitrary range reads for every single chip
> > supported by flashrom.
> >
> > Tests appreciated. Please check if the result of a read with and without
> > the patch is identical. (sha1sum etc. work fine)
> >
> > I need testers with external programmers and testers with onboard chips,
> > with Parallel, LPC, FWH and SPI bus.
> >
> > Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> >   
> 
> More updates to svn HEAD, one debug statement for the issue Uwe is seeing.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

with the small fix discussed in IRC (drop line 706 in spi.c).

The patch is tested on one LPC, one SPI, and one parallel flash board by
me. With the above-mentioned fix, all reads before/after the patch are
identical (I compared MD5 sums).


> +	/* FIXME: This is here for Uwe. */

Drop this I guess (?)


> +	printf_debug("%s: start=%i len=%i chunksize=%i\n", __func__, start, len, chunksize);


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list