[coreboot] [PATCH] flashrom: Support only one operation at a time
uwe at hermann-uwe.de
Fri Jun 12 15:57:26 CEST 2009
On Fri, Jun 12, 2009 at 01:12:17PM +0200, Carl-Daniel Hailfinger wrote:
> flashrom does not honor argument ordering for operations. Not only does
> this violate the principle of least surprise, it also caused one bug
> where -Ewv was specified and the flash ended up being empty.
> Support only one operation at a time.
> As a side benefit, this allows us to clean up main() quite a bit.
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
I agree with Ron that we should not combine commands.
But we _should_ make write/erase autoverify!
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
More information about the coreboot