[coreboot] [PATCH] K8: Improve RAM init debug messages

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Jun 5 22:37:44 CEST 2009

On 05.06.2009 22:06, Myles Watson wrote:
>> Old messages for my machine with 5 GB:
>> RAM: 0x00400000 kB
>> Ram3
>> [...]
>> Initializing memory:  done
>> RAM: 0x00500000 kB
>> New messages:
>> RAM end at 0x00400000 kB, hole starts at 0x00000000 kB
> I liked this one better before.  Here it really means there is 4 GB of RAM.
> The "hole at 0x0" part is not helpful.

Since we already print hole location in a separate function, I'll kill
it here.

>> Handling memory hole at 0x00300000 (default)
>> RAM end at 0x00500000 kB, hole starts at 0x00300000 kB
> Here the new message makes sense.  Do we need to print out the hole start
> again?

Good question. The "Handling memory hole" message is in a separate
function. I'll kill the "hole starts at" message.

>> I hope this helps understand my patch better.
> Yes.  There's nothing like the real output for succinctness.

I'll to do that in the future. Thanks for the hint.

> Acked-by: Myles Watson <mylesgw at gmail.com>

Thanks, committed in r4341.



More information about the coreboot mailing list