[coreboot] [PATCH] flashrom: Add chip_{read,write}n

Uwe Hermann uwe at hermann-uwe.de
Fri Jun 5 20:07:43 CEST 2009

On Fri, Jun 05, 2009 at 05:36:06PM +0200, Carl-Daniel Hailfinger wrote:
> Sometimes we want to read/write more than 4 bytes of chip content at once.
> Add chip_{read,write}n to the external flasher infrastructure which
> read/write n bytes at once.
> Fix a few places where the code used memcpy/memcmp although that is
> strictly impossible with external flashers.
> Place a FIXME in the layout.c code because usage is not totally clear
> and needs to be fixed to support external flashers.
> As a nice side benefit, we get a noticeable speedup for builtin flash
> reading which is now a memcpy() of the full flash area instead of a
> series of single-byte reads.
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


 - Please check the malloc() return value.

 - The patch needs some adaption, doesn't apply anymore to trunk.

Other than that it looks ok.

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

More information about the coreboot mailing list