[coreboot] USB changes

Leandro Dorileo ldorileo at gmail.com
Tue Jul 21 22:30:34 CEST 2009


On Tue, Jul 21, 2009 at 4:29 PM, Leandro Dorileo<ldorileo at gmail.com> wrote:
> Hi Patrick
>
> I have done the changes we discussed previously. Attached follows the
> patches. The 2 first patches are just few changes in the reg
> functions(*read/write*) so we can use the same functions in both OHCI
> and UHCI.
>
> The last patches are related to the changes I proposed to control
> function. I`m copying here the commit log message:
>
> "Changed the usb API where the control function first parameter now
> is a pointer of endpoint_t instead of a pointer of usbdevice_t.
>
> The previous implementation assumed the first endpoint(index 0) as
> control, which is not true, we can have devices with more than a
> single control line."
>
> Since MSC device has always a single control endpoint I kept assuming
> that, and the changes to the drivers do exactly that, takes the first
> endpoint and passes it to control.
>
> I would like to keep those changes upstream already so it can be
> easily maintained. Please review and comment.
>
> PS: I`m cc`ing the coreboot mailing list, this way we can have more reviewers.
>
> Thanks in advance....
>
> --
> (°=   Leandro Dorileo
> //\    ldorileo at gmail.com   -   http://www.dorilex.net
> V_/  Software is a matter of freedom.
>



-- 
(°=   Leandro Dorileo
//\    ldorileo at gmail.com   -   http://www.dorilex.net
V_/  Software is a matter of freedom.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-reg-operations-moving.patch
Type: text/x-diff
Size: 2851 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090721/5bfce6b7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-reg-functions-adaptation-of-uhci-and-uhci_rh.patch
Type: text/x-diff
Size: 9424 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090721/5bfce6b7/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-usb-API-change-control-receive-endpoint_t.patch
Type: text/x-diff
Size: 1244 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090721/5bfce6b7/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-uhci-control-adaptations.patch
Type: text/x-diff
Size: 1539 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090721/5bfce6b7/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-control-users-change-the-callers-of-control.patch
Type: text/x-diff
Size: 4237 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090721/5bfce6b7/attachment-0004.bin>


More information about the coreboot mailing list