[coreboot] [PATCH] some more CONFIG_ prefixes

Stefan Reinauer stepan at coresystems.de
Mon Jul 20 17:45:39 CEST 2009


On 20.07.2009 15:57 Uhr, Myles Watson wrote:
>> attached patch renames some preprocessor symbols. I have no idea why
>> those symbols were left alone before, after this, they're somewhat more
>> in line with the rest of the tree.
>>     
>
>
> @@ -18,8 +18,8 @@
>  #define MAINBOARD_POWER_OFF 0
>  #define MAINBOARD_POWER_ON  1
>  
> -#ifndef MAINBOARD_POWER_ON_AFTER_FAIL
> -#define MAINBOARD_POWER_ON_AFTER_FAIL MAINBOARD_POWER_ON
> +#ifndef CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL
> +#define CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL MAINBOARD_POWER_ON
>  #endif
>
> Since they're #ifndef, that means they weren't part of the old config
> system, or there is a bug.  Those symbols are always defined, and are tested
> based on their values.  Is there a uses statement for them somewhere?
>   

The old config tool has an flag to determine whether an option should be
exported always or only if it is used.

Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090720/362218c6/attachment.html>


More information about the coreboot mailing list