[coreboot] non static < 0x1000 IO space can be broken

Myles Watson mylesgw at gmail.com
Mon Jul 20 16:39:22 CEST 2009

On Mon, Jul 20, 2009 at 8:14 AM, Rudolf Marek <r.marek at assembler.cz> wrote:

> Hi Myles,
>> That's the way the rest of the boards did it.  I'm sorry I missed this
>> southbridge.  I thought I got them all.
> Ok. Please prepare the patch.


Signed-off-by: Myles Watson <mylesgw at gmail.com>

I noticed in your patch that you're setting the limit = base+size-1.  The
>> limit is not the same as the end of the resource.  For most I/O, the limit
>> should be 0xffff.
> aha true. This was cut and paste from k8t890 where it was used to setup
> APIC resource. For mem resource it should be how? I don't understand the
> gran too.

The limit should always be the upper bound that a type of resource could be
set to.  For I/O 0xffff, for MEM, 0xffffffff...

gran sets the granularity of an allocation.  For example, on K8 you have to
allocate I/O to links at least 4K at a time, so the granularity is 12.  gran
and align should never matter for fixed resources.

> For this SB (the VT8237S) we will definitely need to dynamically allocate a
> mmio BAR for SPI controller. I will prepare a patch, but cannot test.
> I would like to ask if you care about the decoding range for flashes - if I
> need some other resource for that and also about 0xfee... for MSI.

Anything above 0xfec... doesn't matter, since you have an APIC resource

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090720/a53148d7/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vt8237r.diff
Type: text/x-patch
Size: 763 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090720/a53148d7/attachment.diff>

More information about the coreboot mailing list