[coreboot] [flashrom] [PATCH] external serial flasher protocol support

Warren Turkal wt at penguintechs.org
Mon Jul 13 10:32:33 CEST 2009

On Fri, Jul 10, 2009 at 3:56 PM, Urja Rannikko<urjaman at gmail.com> wrote:
> +       printf_debug("%s: addr=0x%lx len=%lu\n", __func__, addr, (unsigned long)len);

I'm almost certain that it'd be better to user %z in the printf string
here instead of casting to unsigned long and using %lu in the printf

Also, I think it'd be nice to see a major reduction in the number of
casts used in the code if possible. Casts have a real potential to
introduce really subtle errors into the code.


More information about the coreboot mailing list