[coreboot] r4394 breaks on hardware (was: Re: [PATCH] v3 Resource allocator to v2)

[Myles Watson]

> -----Original Message-----
> From: Uwe Hermann [mailto:uwe at hermann-uwe.de]
> Sent: Sunday, July 05, 2009 5:14 PM
> To: Myles Watson
> Cc: 'ron minnich'; coreboot at coreboot.org
> Subject: Re: r4394 breaks on hardware (was: Re: [coreboot] [PATCH] v3
> Resource allocator to v2)
> 
> On Sat, Jul 04, 2009 at 07:41:09PM -0600, Myles Watson wrote:
> > > > Rev 4394.
> > >
> > > This patch seems to cause trouble, at least on the Kontron board where
> I
> > > tested recent trunk, but probably on other systems also I'd guess.
> > It could be, but the problem you're seeing is Kontron-specific.
> 
> Hm, possible, but then there are other issues in the new code I guess.
> Here are two dumps of r4393/r4394 from the MS-6178 (i810) board.
Thanks for testing.  That breakage is different.

> The first one works fine and shows a FILO menu (on serial), the second
> one contains lots of "!! Resource didn't fit !!" lines among other
> things, and I see a totally garbled or blank FILO screen (on serial) and
> it seems to hang at that point.
    PNP: 002e.6 resource base 0 size 8 align 3 gran 3 limit 7ff flags 100
index 60
    PNP: 002e.6 resource base 0 size 1 align 0 gran 0 limit 0 flags 400
index 70

The problem here is that these two resources are not fixed.  Since the limit
is set to 7ff on 2e.6 @ 60, the resource allocator tries to fit everything
into 0-7ff.  If you make this resource fixed, or remove them, the problem
will disappear.

In your old log, both of those resources end up at 0, which is not good.

Thanks,

Myles



> > You can chime in.
> 
> Not really, I don't know enough about this stuff to post useful comments,
> sorry.
The point of the new allocator was to make it easier to debug and fix
resource allocation problems.  Hopefully it is less magical than it was, but
I'm happy to help fix all the problems that come up.

Thanks,
Myles