[coreboot] [PATCH] flashrom patch easier board_pciid_enables parsing

[Carl-Daniel Hailfinger]

On 15.01.2009 04:24, Luc Verhaegen wrote:
> On Thu, Jan 15, 2009 at 03:44:41AM +0100, Carl-Daniel Hailfinger wrote:
>   
>> On 15.01.2009 03:49, Luc Verhaegen wrote:
>>     
>>>   
>>> Daniel, you just bloated an almost overseeable table 7fold. If you claim 
>>> that you still have any oversight and any control, then you're lying.
>>>   
>>>       
>> Rest assured, I'll sleep well tonight.
>>
>>     
>>> Luc Verhaegen.
>>> Who just happens to be the original creator of this table.
>>>   
>>>       
>> The new table has a format which elicits a WTF for several entries. The
>> reason for the WTF (content, not style) was there already, but the old
>> style didn't make it that obvious. Making things obvious is good. Making
>> strange code painful to look at is good.
>>     
>
> Hey, if you don't understand the code, don't touch it.
>   

No problem. I assume you're willing to create all board enable functions
and table entries for the foreseeable future for everyone who asks once
we switch back to the old layout. That includes debugging and sending
new patches to volunteer testers.
By the way, I understand the code.


> And here i was thinking there was a clear comment in front of the table 
> structure definition that explained how the different entries are used 
> and why some entries can be nulled.
>   

Calling subsystem IDs card IDs is not my definition of clear.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/