[coreboot] [PATCH] flashrom patch easier board_pciid_enables parsing

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Jan 15 03:44:41 CET 2009

On 15.01.2009 03:49, Luc Verhaegen wrote:
> On Thu, Jan 15, 2009 at 03:09:10AM +0100, Luc Verhaegen wrote:
>> On Thu, Jan 15, 2009 at 02:14:12AM +0100, Peter Stuge wrote:
>>> Carl-Daniel Hailfinger wrote:
>>>> r3861
>>> ..just horrible..
>> Acked-By Luc Verhaegen <libv at skynet.be>
> Heck, i tried getting some sleep after seeing this but failed.
> This change goes in against every instinct i have.
> diffstat tells me this:
>  board_enable.c |  413 +++++++++++++++++++++++++++++++++++++++++++++++++--------
>  1 file changed, 362 insertions(+), 51 deletions(-)
> Daniel, you just bloated an almost overseeable table 7fold. If you claim 
> that you still have any oversight and any control, then you're lying.

Rest assured, I'll sleep well tonight.

> Luc Verhaegen.
> Who just happens to be the original creator of this table.

The new table has a format which elicits a WTF for several entries. The
reason for the WTF (content, not style) was there already, but the old
style didn't make it that obvious. Making things obvious is good. Making
strange code painful to look at is good.

Who thinks lots of lines with =0 or =NULL can be removed now which was
impossible with the old style.


More information about the coreboot mailing list