[coreboot] [PATCH] flashrom patch easier board_pciid_enables parsing

Luc Verhaegen libv at skynet.be
Thu Jan 15 03:49:07 CET 2009


On Thu, Jan 15, 2009 at 03:09:10AM +0100, Luc Verhaegen wrote:
> On Thu, Jan 15, 2009 at 02:14:12AM +0100, Peter Stuge wrote:
> > Carl-Daniel Hailfinger wrote:
> > > r3861
> > 
> > ..just horrible..
> 
> Acked-By Luc Verhaegen <libv at skynet.be>

Heck, i tried getting some sleep after seeing this but failed.

This change goes in against every instinct i have.

diffstat tells me this:
 board_enable.c |  413 +++++++++++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 362 insertions(+), 51 deletions(-)

Daniel, you just bloated an almost overseeable table 7fold. If you claim 
that you still have any oversight and any control, then you're lying.

Luc Verhaegen.
Who just happens to be the original creator of this table.




More information about the coreboot mailing list