[coreboot] r3847 - in trunk/coreboot-v2/src/mainboard/amd: dbm690t pistachio

svn at coreboot.org svn at coreboot.org
Tue Jan 6 17:45:42 CET 2009


Author: mjones
Date: 2009-01-06 17:45:42 +0100 (Tue, 06 Jan 2009)
New Revision: 3847

Modified:
   trunk/coreboot-v2/src/mainboard/amd/dbm690t/acpi_tables.c
   trunk/coreboot-v2/src/mainboard/amd/pistachio/acpi_tables.c
Log:
The ACPI PSS CPU Pstate table was calculating the frequency incorrectly for
revF CPUs. The 100MHz/200MHz stepping is already handled in the FID setting
and doesn't need to be checked to set the fid_multiplier. The multiplier is
always 100.

Signed-off-by: Marc Jones <marcj303 at gmail.com>
Acked-by: zheng bao <zheng.bao at amd.com>

Modified: trunk/coreboot-v2/src/mainboard/amd/dbm690t/acpi_tables.c
===================================================================
--- trunk/coreboot-v2/src/mainboard/amd/dbm690t/acpi_tables.c	2009-01-06 00:33:30 UTC (rev 3846)
+++ trunk/coreboot-v2/src/mainboard/amd/dbm690t/acpi_tables.c	2009-01-06 16:45:42 UTC (rev 3847)
@@ -258,12 +258,11 @@
 		return 0;
 	}
 
-	/*get the multipier of the fid frequency */
+	/* Get the multipier of the fid frequency */
 	/*
-	 * In RevG, 100MHz step is added
+	 * Fid multiplier is always 100 revF and revG.
 	 */
-	cpuid1 = cpuid(0x80000007);
-	fid_multiplier = ((cpuid1.edx & 0x40) >> 6) * 100;
+	fid_multiplier = 100;
 
 	/*
 	 * Formula1:    CPUFreq = FID * fid_multiplier + 800

Modified: trunk/coreboot-v2/src/mainboard/amd/pistachio/acpi_tables.c
===================================================================
--- trunk/coreboot-v2/src/mainboard/amd/pistachio/acpi_tables.c	2009-01-06 00:33:30 UTC (rev 3846)
+++ trunk/coreboot-v2/src/mainboard/amd/pistachio/acpi_tables.c	2009-01-06 16:45:42 UTC (rev 3847)
@@ -258,12 +258,11 @@
 		return 0;
 	}
 
-	/*get the multipier of the fid frequency */
+	/* Get the multipier of the fid frequency */
 	/*
-	 * In RevG, 100MHz step is added
+	 * Fid multiplier is always 100 revF and revG.
 	 */
-	cpuid1 = cpuid(0x80000007);
-	fid_multiplier = ((cpuid1.edx & 0x40) >> 6) * 100;
+	fid_multiplier = 100;
 
 	/*
 	 * Formula1:    CPUFreq = FID * fid_multiplier + 800





More information about the coreboot mailing list