[coreboot] r1137 - in coreboot-v3/arch/x86: . intel/core2
Stefan Reinauer
stepan at coresystems.de
Sat Feb 21 18:38:53 CET 2009
svn at coreboot.org wrote:
> Modified:
> coreboot-v3/arch/x86/intel/core2/init_cpus.c
> coreboot-v3/arch/x86/secondary.S
> Log:
> This is a trivial commit and I want to get other people to look at the code.
>
> I can still get to linux but core1 is not work
> Modified: coreboot-v3/arch/x86/secondary.S
> ===================================================================
> --- coreboot-v3/arch/x86/secondary.S 2009-02-21 00:05:20 UTC (rev 1136)
> +++ coreboot-v3/arch/x86/secondary.S 2009-02-21 17:28:24 UTC (rev 1137)
> @@ -23,10 +23,9 @@
> */
> .text
> .globl _secondary_start, _secondary_start_end
> - .balign 4096
> _secondary_start:
> .code16
> - .long 0
> + .balign 4096
> cli
>
This looks bogus.
> /* Set the stack pointer */
> - movl _secondary_start, %esp
> + movl $_secondary_start-4,%eax
> + movl 0x0(%eax),%esp
>
Why?
Stefan
More information about the coreboot
mailing list