[coreboot] [patch] flashrom: resending my patch about SPI/LPC conflicts
ward at gnu.org
Fri Feb 20 19:03:49 CET 2009
On Fri, Feb 20, 2009 at 06:53:24PM +0100, Peter Stuge wrote:
> Ward Vandewege wrote:
> > > It's not a very generic fix. It's basically a compile time decision
> > > whether to use SPI or LPC on SB600 chipsets.
> > I understand. It works around the hang for me.
> But it breaks all SB600 boards with SPI flash.
Ah, I didn't realize that.
> > > Is there no way we can detect what the system booted from?
> > Is that what should decide which rom to flash?
> I think that is the best we can do at this point.
> > Are there scenarios where that would cause problems?
> I can't think of one. Do you have something in mind?
I was wondering if there would be a case where you boot from an SPI rom and
wanted to flash PLCC or something like that. But let's ignore that for now.
> > I suppose the 'easiest' way to fix this would be adding a command
> > line option that forces LPC/SPI?
> It just makes me really sad and annoyed to require manual control
> like that when the SB600 for all other flash chip purposes is totally
> excellent - nice and simple! I just don't want to believe that noone
> thought of mirroring the boot straps in some register.
Oh, that would be very sad indeed.
> > Or, perhaps make the decision based on which board is detected?
> Could do - would require every SB600 board to have an explicit
> board_enable entry..
Or maybe just the ones that we know have LPC? That's what I was thinking.
Ward Vandewege <ward at fsf.org>
Free Software Foundation - Senior Systems Administrator
More information about the coreboot