[coreboot] dos2unix

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Feb 12 20:27:40 CET 2009


On 12.02.2009 20:23, Carl-Daniel Hailfinger wrote:
> On 12.02.2009 18:54, Myles Watson wrote:
>   
>> In the spirit of trivial but large patches, here are two more.
>>
>> Signed-off-by: Myles Watson <mylesgw at gmail.com>
>>   
>>     
>
> AFAICS your change is safe for printk_*. Ron has a point about print_*
> which is used in ROMCC compiled code.
> By the way, there are lots of files which are not compiled with romcc
> and still use print_* instead of printk_*.
>
> Rule of thumb: All K8 targets and all GeodeLX targets should be free of
> ROMCC compiled code.
>   

Let me rephrase that:
All K8 and GeodeLX targets are in need of a print_* -> printk_*
conversion. And printk_* does not need DOS line endings.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list