[coreboot] [PATCH] Warn if we run out of MTRRs

Stefan Reinauer stepan at coresystems.de
Thu Feb 12 17:35:00 CET 2009


Peter Stuge wrote:
> Carl-Daniel Hailfinger wrote:
>   
>>> Would it work to add a third negative MTRR for that region?
>>>       
>> It would be two negative MTRRs in that case.
>>     
>
> Yes. And the new one would be the third.
>   
The third used MTRR. The second negative MTRR.

>>> If yes, that's what I would like, and then I say to Stefan's patch:
>>>       
>> You do realize that solving this problem means either adding another
>> special case for SMM or discarding Stefan's patch?
>>     
>
> The former. KISS.
>   
Carl-Daniel: if you solve the problem wit an algorithm that is easier to
understand and/or shorter than the current code with 2 special cases,
let's review your _code_ and I'm sure enough people will Ack it. Don't
discuss discarding my patches with empty hands, I tend to react allergic
to that.

I'm not getting tired of repeating myself.:There should not be a reason
to un-cache the upper SMM area, or the problem is elsewhere. There is
definitely no issue with any of my SMM code, and there is no other SMM
code in the public tree or on the mailing list. So once that problem
will occur, we can solve that problem.

Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866






More information about the coreboot mailing list