[coreboot] [PATCH] Cleanup/remove update_ssdt

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Feb 3 05:10:53 CET 2009

On 03.02.2009 01:30, Carl-Daniel Hailfinger wrote:
> On 01.02.2009 17:15, Rudolf Marek wrote:
>> Hello,
>> Following patch converts the run-time SSDT patching via update_ssdt
>> funtion to
>> new AML code generator. Compile-tested on all changed targets. I think
>> it should
>> work because it works for Asus M2V-MX SE.
>> Signed-off-by: Rudolf Marek <r.marek at assembler.cz>
>> Perhaps also some private SSDTs of each MB could be also somehow
>> converted. Its
>> quite complicated and I dont own any board to test, so lets just
>> convert the
>> generic stuff.
> Some comments on the patch:
> It does not apply cleanly against the latest tree, but that's probably
> just minor.
> mainboard/amd/dbm690t/acpi_tables.c still has AmlCode_ssdt somewhere
> in there.
> iwill/dk8_htx and agami/aruma still reference the old ssdt code in their
> Config.lb.
> Having the same code for Fam10h would be great and probably shrink the
> differences between K8 and Fam10 even further. We need to merge that
> code anyway.
> Overall, I like the patch. I'll boot the old and the new code and dump
> my ACPI tables so you can take a look.

Old and new ACPI tables are attached. Please ignore the TOM and TOM2
values in the DSDT. They are wrong (mainboard code bug).
Unless I'm missing something, your code produces a SSDT which is
identical to the previous one on my Asus M2A-VM (690G/SB600) board.

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>




-------------- next part --------------
A non-text attachment was scrubbed...
Name: acpitables_ssdt_rewrite.tar.gz
Type: application/x-gzip
Size: 24139 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090203/ca783722/attachment.gz>

More information about the coreboot mailing list