[coreboot] [PATCH]unify types in kconfig

Uwe Hermann uwe at hermann-uwe.de
Tue Aug 25 19:14:48 CEST 2009

On Tue, Aug 25, 2009 at 10:58:44AM -0600, Myles Watson wrote:
> > attached patch makes PCI_ROM_RUN a boolean (like it is elsewhere), which
> > is the correct choice, too. Avoids type problems in kconfig
> I agree with the type change.

Ditto, I was going to post the same patch also :)

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

> I think setting it in a mainboard Kconfig is
> a mistake.  I tried to build Serengeti_cheetah without VGA to test something
> and it was a pain.

Hm, you could be right. This was per-mainboard in Config.lb, but in
kconfig it should be a global/common option, and not set in each board.

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

More information about the coreboot mailing list