[coreboot] [patch] Fixed the LZMA compression flag in Kbuild

ron minnich rminnich at gmail.com
Sat Aug 22 23:25:15 CEST 2009


Here are all uses I could fine.
Defaults to 0 in old config tool.
Set to 1 if used in new config tool.

If src/Kconfig it is:
config COMPRESSED_PAYLOAD_LZMA
        bool
        default y

So we have a problem. Here are the usages I could find.

src/mainboard/intel/eagleheights/Options.lb:default
CONFIG_COMPRESSED_PAYLOAD_LZMA=1
src/lib/Config.lb:if CONFIG_COMPRESSED_PAYLOAD_LZMA
src/lib/Makefile.inc:obj-$(CONFIG_COMPRESSED_PAYLOAD_LZMA)  +=  lzma.o
src/arch/i386/Config.lb:makedefine
PAYLOAD-$(CONFIG_COMPRESSED_PAYLOAD_LZMA):=payload.lzma
src/arch/i386/Config.lb:		action "if [
$(CONFIG_COMPRESSED_PAYLOAD_LZMA) -eq 1 -a $(CONFIG_CBFS) -eq 1 ];
then echo l > cbfs-support; fi"
src/stream/rom_stream.c:#if CONFIG_PRECOMPRESSED_PAYLOAD &&
((!CONFIG_COMPRESSED_PAYLOAD_NRV2B) &&
(!CONFIG_COMPRESSED_PAYLOAD_LZMA))
src/stream/rom_stream.c:#error "You set CONFIG_PRECOMPRESSED_PAYLOAD
but need to set CONFIG_COMPRESSED_PAYLOAD_NRV2B or
CONFIG_COMPRESSED_PAYLOAD_LZMA"
src/stream/rom_stream.c:#if ((CONFIG_COMPRESSED_PAYLOAD_NRV2B) ||
(CONFIG_COMPRESSED_PAYLOAD_LZMA))
src/stream/rom_stream.c:#if (CONFIG_COMPRESSED_PAYLOAD_LZMA)
src/stream/rom_stream.c:#if (CONFIG_COMPRESSED_PAYLOAD_LZMA)
src/stream/serial_stream.c:#if CONFIG_PRECOMPRESSED_PAYLOAD &&
((!CONFIG_COMPRESSED_PAYLOAD_NRV2B) &&
(!CONFIG_COMPRESSED_PAYLOAD_LZMA))
src/stream/serial_stream.c:#error "You set
CONFIG_PRECOMPRESSED_PAYLOAD but need to set
CONFIG_COMPRESSED_PAYLOAD_NRV2B or CONFIG_COMPRESSED_PAYLOAD_LZMA"
src/stream/serial_stream.c:#if (CONFIG_COMPRESSED_PAYLOAD_LZMA)
src/stream/serial_stream.c:#if (CONFIG_COMPRESSED_PAYLOAD_LZMA)
src/boot/selfboot.c:#if CONFIG_COMPRESSED_PAYLOAD_LZMA==1

It needs to be 'y' for Kconfig but it will have to be fixed in all the
old usages. This is not a big deal to fix. We should change it
so old config tool uses 'y', since old config tool is on its way out anyway.

But the patch is not complete. If it were committed it would break all
the old config builds.

ron




More information about the coreboot mailing list