[coreboot] [PATCH] various things to aid with CBFS on PPC, plus...

[Stefan Reinauer]

On 8/19/09 11:08 PM, Patrick Georgi wrote:
> +static int tohex8(int c)
> +{
> +	return (c<=9)?(c+'0'):(c-10+'a');
> +}
> +
> +static void tohex32(int val, char* dest)
> +{
> +	dest[0]=tohex8(val>>24);
> +	dest[1]=tohex8((val>>16) & 0xff);
> +	dest[2]=tohex8((val>>8) & 0xff);
> +	dest[3]=tohex8((val) & 0xff);
> +}
>   
I think I agree with Myles, those val/c should probably be u8 and u32?

Acked-by: Stefan Reinauer <stepan at coresystems.de>

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866