[coreboot] [PATCH]The resource allocator does not like zero-sized fixed resources

Patrick Georgi patrick at georgi-clan.de
Wed Aug 19 18:14:18 CEST 2009


attached patch fixes a small issue with the resource allocator. In a 
loop in which only fixed resources are processed, zero-sized resources 
were able to modify the limits used for resource allocation in a later 
phase. This leads to overlapping resources on kontron.
I had a patch for that a while ago already, but this one is much cleaner 
and much more obvious in its intent.
If you think there shouldn't be zero-sized fixed resources, please take 
a look at src/devices/pci_device.c, line 331. There, a fixed resource 
with no size is created, and there is no obvious value to set for size.

Even if there shouldn't be such resources, I think it's still good to 
prevent them from causing trouble if they appear.

Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 20090819-1-resource-allocator-does-not-like-zerosized-fixed-resources.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090819/ae8c9623/attachment.ksh>

More information about the coreboot mailing list