[coreboot] vga not working

[Arnaud Maye]

Hello Kevin,

Kevin O'Connor wrote:
> On Mon, Aug 17, 2009 at 01:21:17PM +0200, Arnaud Maye wrote:
>   
>> I've got the VGA to operating correctly in seabios. Actually it was
>> as simple as enabling the VGA forwarding on the pci root complex, in
>> the northbridge. Actually during the coreboot boot, the VGA output
>> does not make much sense but as soon the OS boots, I can see the
>> complete boot.
>>     
>
> Great!
>
>   
>> This bit can be set for one PCIe "port" or the other, actually two
>> possible settings but both cannot be enabled in the same time. So
>> the bit to set depends where the GFX card is attached in fact.
>> Should we proceed with this "detection" to set the correct bit or
>> can we assume the user connects his card to PCIe SLOT0, in this case
>> we hard code the correct bit setting for PCIe SLOT0?
>>
>> So far I am doing this in the auto.c file after the RAM
>> verification, and this is not the best place to do that, I
>> know. Where would be the best place to patch that in? In a way we
>> are only setting one bit nothing more.
>>     
>
> As far as I know, this is supposed to be done by the option
> CONFIG_CONSOLE_VGA.  (For example, see set_vga_bridge_bits() in
> src/devices/device.c.)  If that option isn't setting all the bits,
> then it sounds like it needs to be extended.
>   
Actually this function does not set any bits to the hardware I believe. 
Just setting up some bits in the
device structure. The bit enable thing for the root complex is going to 
be 80579 specific not sure it should
be part of this file. Actually enabling these bits means write to the 
PCI configuration space.

I guess I could add a vga_enable.c part of northbridge/i3100 and call 
this function from auto.c or
something like that, not sure if that would be fine or not.

Thank you

Arnaud

> -Kevin
>
>   

*
*