[coreboot] [v2] r4525 - trunk/coreboot-v2/src/cpu/x86/mtrr

svn at coreboot.org svn at coreboot.org
Tue Aug 11 05:18:11 CEST 2009


Author: zbao
Date: 2009-08-11 05:18:11 +0200 (Tue, 11 Aug 2009)
New Revision: 4525

Modified:
   trunk/coreboot-v2/src/cpu/x86/mtrr/mtrr.c
Log:
The code between #if and #endif is only about UMA mode. The CONFIG_GFXUMA should be 1.
We have another mode called side port mode. It is When the CONFIG_GFXUMA is 0.

Signed-off-by: Zheng Bao <zheng.bao at amd.com>
Acked-by: Myles Watson <mylesgw at gmail.com>


Modified: trunk/coreboot-v2/src/cpu/x86/mtrr/mtrr.c
===================================================================
--- trunk/coreboot-v2/src/cpu/x86/mtrr/mtrr.c	2009-08-10 15:57:05 UTC (rev 4524)
+++ trunk/coreboot-v2/src/cpu/x86/mtrr/mtrr.c	2009-08-11 03:18:11 UTC (rev 4525)
@@ -418,7 +418,7 @@
 	search_global_resources(
 		IORESOURCE_MEM | IORESOURCE_CACHEABLE, IORESOURCE_MEM | IORESOURCE_CACHEABLE,
 		set_var_mtrr_resource, &var_state);
-#ifdef CONFIG_GFXUMA
+#if (CONFIG_GFXUMA == 1) /* UMA or SP. */
 	// For now we assume the UMA space is at the end of memory
 	if (var_state.hole_startk || var_state.hole_sizek) {
 		printk_debug("Warning: Can't set up MTRR hole for UMA due to pre-existing MTRR hole.\n");





More information about the coreboot mailing list