[coreboot] [PATCH] cld before call

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Aug 1 03:55:20 CEST 2009


On 29.07.2009 00:36, Robert Millan wrote:
> The Multiboot spec is a bit too permissive about this, as it doesn't
> specify the state of direction flag when payload is called.  Some payloads
> (we found this in ReactOS FreeLDR) assume it is cleared, and fail otherwise.
>
> We adjusted GRUB to be sure it's always cleared.  I think coreboot should do
> the same.  Here's a patch for v3.
>
> Signed-off-by:  Robert Millan <rmh.coreboot at aybabtu.com>
>   

Thanks to the explanation provided by Segher, I now know your patch is
the right thing to do.
Robert, thanks for digging this up.

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list