[coreboot] SeaBIOS and hp dl145g3

[Myles Watson]

On Thu, Apr 30, 2009 at 9:07 AM, samuel <samuel.verstraete at gmail.com> wrote:
> On Thu, Apr 30, 2009 at 2:43 AM, Kevin O'Connor <kevin at koconnor.net> wrote:
>> On Wed, Apr 29, 2009 at 04:53:13PM +0200, samuel wrote:
>>> Hi Kevin,
>>>
>>> I have tried Seabios on my hp dl145 g3 (the patches from mondrian) and
>>> it works really well now
>>> I was able to load the vga rom and i have output on the screen.
>>
>> Great!
>>
>>> One single problem... It doesn't seem to find the sata controller...
>>>
>>> bootlog with coreboot and seabios:
>>> http://merlin.ugent.be/~samuel/dl145g3/corebootwithseabios.log
>>
>> There isn't much SeaBIOS info in that log - can you recompile with
>> CONFIG_DEBUG_LEVEL set to 6?
>
> did that: see http://merlin.ugent.be/~samuel/dl145g3/coreboot_seabios_DEBUG6.log
>
>>
>>>
>>> lspci -vnn : http://merlin.ugent.be/~samuel/dl145g3/info/lspci-vnn.txt

01:0e.0 RAID bus controller [0104]: Broadcom BCM5785 [HT1000] SATA
(Native SATA Mode) [1166:024a] (prog-if 05)

http://pci-ids.ucw.cz/read/PC/1166/024b says:

The device starts as 024a, and changes to 024b if set to PATA mode in BIOS

>>> You have any ideas how i could quickly add support for the hp dl145 g3
>>> to SeaBIOS??
>>
>> The equivalent patch in SeaBIOS would look like:
>>
>> --- a/src/ata.c
>> +++ b/src/ata.c
>> @@ -841,7 +845,8 @@ ata_init()
>>     int count=0;
>>     int bdf, max;
>>     foreachpci(bdf, max) {
>> -        if (pci_config_readw(bdf, PCI_CLASS_DEVICE) != PCI_CLASS_STORAGE_IDE)
>> +        u16 class = pci_config_readw(bdf, PCI_CLASS_DEVICE);
>> +        if (class != PCI_CLASS_STORAGE_IDE && class != PCI_CLASS_STORAGE_RAID)
>>             continue;
>>         if (count >= ARRAY_SIZE(ATA.channels))
>>             break;

This forces SeaBIOS to see it as a PATA controller, but it's in SATA mode.

Kevin,

Is there an easy way to add SATA support to SeaBIOS?  It sounds like a
bit of work.  It looks like you could force the device to be in PATA
mode, but once it's booted that's not ideal.

Maybe there's another option we haven't thought of.

Thanks,
Myles