[coreboot] [PATCH] VIA C7 CAR doesn't configure the stack pointer

Myles Watson mylesgw at gmail.com
Mon Apr 27 20:18:28 CEST 2009

> the attached patch sets up the stack pointer in the c7 CAR-post routine,
> to
> make function calls work in the small area after CAR and before
> coreboot_ram.
> For sufficient high loglevels, there are two printk_*s in generic CAR code
> that made the system reboot. (with my preceding patch, it crashes for all
> loglevel configurations and an issue like this one would have been found
> directly)
> Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>

The stack pointer is a magic value to me.  Could you add a comment stating
why you chose 0x400000?  Maybe that will help someone decide whether it
needs to change later for suspend-to-RAM.

Acked-by: Myles Watson <mylesgw at gmail.com>


More information about the coreboot mailing list