[coreboot] [PATCH] move i386 specific sleep code out of hardwaremain.c

[Stefan Reinauer]

On 22.04.2009 18:30 Uhr, Stefan Reinauer wrote:
> On 22.04.2009 18:00 Uhr, Peter Stuge wrote:
>>> +#if MEM_TRAIN_SEQ != 0
>>> +	#error "So far it works on AMD and MEM_TRAIN_SEQ == 0"
>>> +#endif
>>> +
>>> +#if _RAMBASE < 0x1F00000
>>> +	#error "For ACPI RESUME you need to have _RAMBASE at least 31MB"
>>> +	#error "Chipset support (S3_NVRAM_EARLY and ACPI_IS_WAKEUP_EARLY functions and memory ctrl)"
>>> +	#error "And coreboot memory reserved in mainboard.c"
>>> +#endif
>>> +#endif
>>>     
>> +#if 0
>>
>> Why disable these build time checks?
>>
>>
>> //Peter
>>
>>   
> Because they don't belong in i386 generic code either.. They're
> mainboard or chipset or CPU specific limitations. Many chipsets have
> no variable named MEM_TRAIN_SEQ
For a better explanation: The code should go away or go to the right
place. I have a lot less bellyache if they're in arch/i386/boot/acpi but
that's not their final location.  Maybe the checks should go away
completely. Or to the AMD northbridge directory?

But before I deleted it, I  left it in, commented out. One thing for
sure, their place is NOT hardwaremain.c

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090422/f0e5ddf9/attachment.html>