[coreboot] [PATCH] flashrom: Reflect generic match status more accurately

Uwe Hermann uwe at hermann-uwe.de
Wed Apr 22 14:41:25 CEST 2009

On Wed, Apr 22, 2009 at 01:43:14AM +0200, Carl-Daniel Hailfinger wrote:
> All "unknown xy SPI chip" entries claim to have status UNTESTED for
> probe/read/erase/write. That is incorrect.
> A bit of confusion comes from how the #defines are named. We call them
> TEST_BAD_*, but the message printed by flashrom says:
> "This flash part has status NOT WORKING for operations:"
> Something that is unimplemented is definitely not working.
> Neither of the chip entries mentioned above has erase or write functions
> implemented, so erase and write are not working.
> Since their size is unknown, we can't read them in. That means read is
> not working as well.
> Probing is a different matter. If a chip-specific probe function had
> matched, we wouldn't have to handle the chip with the "unknown xy SPI
> chip" fallback. I'm tempted to call that "not working" as well, but I'm
> open to discussion on this point.
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Sounds reasonable.

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

More information about the coreboot mailing list