[coreboot] [PATCH] flashrom: Reflect generic match status more accurately

[Carl-Daniel Hailfinger]

All "unknown xy SPI chip" entries claim to have status UNTESTED for
probe/read/erase/write. That is incorrect.

A bit of confusion comes from how the #defines are named. We call them
TEST_BAD_*, but the message printed by flashrom says:
"This flash part has status NOT WORKING for operations:"

Something that is unimplemented is definitely not working.

Neither of the chip entries mentioned above has erase or write functions
implemented, so erase and write are not working.
Since their size is unknown, we can't read them in. That means read is
not working as well.
Probing is a different matter. If a chip-specific probe function had
matched, we wouldn't have to handle the chip with the "unknown xy SPI
chip" fallback. I'm tempted to call that "not working" as well, but I'm
open to discussion on this point.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

 Index: flashrom-test_bad/flashchips.c
===================================================================
--- flashrom-test_bad/flashchips.c	(Revision 4162)
+++ flashrom-test_bad/flashchips.c	(Arbeitskopie)
@@ -2167,7 +2167,7 @@
 		.model_id	= GENERIC_DEVICE_ID,
 		.total_size	= 0,
 		.page_size	= 256,
-		.tested		= TEST_UNTESTED,
+		.tested		= TEST_BAD_PREW,
 		.probe		= probe_spi_rdid,
 		.erase		= NULL,
 		.write		= NULL,
@@ -2180,7 +2180,7 @@
 		.model_id	= GENERIC_DEVICE_ID,
 		.total_size	= 0,
 		.page_size	= 256,
-		.tested		= TEST_UNTESTED,
+		.tested		= TEST_BAD_PREW,
 		.probe		= probe_spi_rdid,
 		.erase		= NULL,
 		.write		= NULL,
@@ -2193,7 +2193,7 @@
 		.model_id	= GENERIC_DEVICE_ID,
 		.total_size	= 0,
 		.page_size	= 256,
-		.tested		= TEST_UNTESTED,
+		.tested		= TEST_BAD_PREW,
 		.probe		= probe_spi_rdid,
 		.erase		= NULL,
 		.write		= NULL,
@@ -2206,7 +2206,7 @@
 		.model_id	= GENERIC_DEVICE_ID,
 		.total_size	= 0,
 		.page_size	= 256,
-		.tested		= TEST_UNTESTED,
+		.tested		= TEST_BAD_PREW,
 		.probe		= probe_spi_rdid,
 		.erase		= NULL,
 		.write		= NULL,
@@ -2219,7 +2219,7 @@
 		.model_id	= GENERIC_DEVICE_ID,
 		.total_size	= 0,
 		.page_size	= 256,
-		.tested		= TEST_UNTESTED,
+		.tested		= TEST_BAD_PREW,
 		.probe		= probe_spi_rdid,
 		.erase		= NULL,
 		.write		= NULL,
@@ -2232,7 +2232,7 @@
 		.model_id	= GENERIC_DEVICE_ID,
 		.total_size	= 0,
 		.page_size	= 256,
-		.tested		= TEST_UNTESTED,
+		.tested		= TEST_BAD_PREW,
 		.probe		= probe_spi_rdid,
 		.erase		= NULL,
 		.write		= NULL,


-- 
http://www.hailfinger.org/

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: flashrom_test_bad03.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090422/669937e2/attachment.ksh>