[coreboot] [PATCH] Factor out ROM size calculation from Config.lb

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Apr 21 02:36:19 CEST 2009

On 21.04.2009 01:32, ron minnich wrote:
> so send me a Config.lb fragment that tickles the bug and I'll look

The big problem is that the trigger mechanism is totally unclear. The
parser will stumble on fragments which are totally sane.

Basically, if you move some code from a Config.lb to an include file and
the code is bit-for-bit identical, the parser still may barf at the end
of the include file with the error message Myles posted. Insert the
content of the include file where the include statement is, and
everything works. I somehow have the feeling that the parser dislikes
the end of include files. It often tries to find something there and fails.

And as Myles demonstrated, even if it works for me in abuild, it may
still fail for him.



More information about the coreboot mailing list