[coreboot] [PATCH] flashrom - board enable - reconstruct table.

Peter Stuge peter at stuge.se
Mon Apr 20 14:45:14 CEST 2009

Luc Verhaegen wrote:
> This patch restores the pciid based board matching table. It makes this
> table readable and hackable again, and the only disadvantage is that the
> right margin is way beyond the rather dogmatic 80. All 0x0000 pci ids have
> been string replaced by 0 to more easily spot missing ids, and extra
> comments have been added to explain how the various entries are used.
> Signed-Off-By: Luc Verhaegen <libv at skynet.be>

Thanks! r4142.

Carl-Daniel Hailfinger wrote:
> The documentation part can be committed after one more iteration.

I took the liberty of improving the wording a little.

> The rest of the patch makes board entries unreadable.

I disagree very much, and I welcome this patch because I naked the
original change.

> In the past few weeks, we had quite a few people in #coreboot who
> wanted to add support for their boards. The presence of struct
> member names helped immensely to explain how to add board enables.

Yes, and I added most of them after quickly looking over lspci -vnn
output to find the most suitable PCI ids.

> Lowering the barrier for possible future developers is very
> important.

A table is a table. Those who understand the concept still understand
it whether the table is really long or really wide.

However, a high degree of noise, such as many redundant member names,
really makes it more difficult to process the signal, such as
different hex PCI ids.

> feel free to submit any new board enables in the single-line
> layout. I'll fix them up.

While a very noble offer, it's not so practical for each change to
have to pass you.

Thanks Luc.


More information about the coreboot mailing list