[coreboot] [PATCH] Factor out ROM size calculation from Config.lb

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Apr 20 14:11:12 CEST 2009

On 20.04.2009 13:41, Peter Stuge wrote:
> Carl-Daniel Hailfinger wrote:
>> Can we please keep the naming of these files consistent?
> Maybe think of it as migration. I think Kconfig will take a while.

And I'd like to separate migration and include file refactoring into two
separate commits.

>> Right now, I can do a
>> find -name "*.lb"
>> and get all config and include files. If I rename the include files
>> only, that will no longer work.
> Right, you'll have to use
> find -name '*.[lc]b'
> instead.

Correct. It's doable, but neither obvious nor documented. Some
documentation for this would be really nice. That's why I want to
postpone that part into another commit.

>> And given that Ron wants to convert most of the stuff to real
>> makefiles anyway,
> I want that too, but I think we will be doing many other improvements
> before that one.

OK. So there will probably be some intermediary stage.

>> I am not sure we want to break vendor/developer trees twice (once
>> for .lb->.bc and once for real makefiles).
> It's a good point to not break stuff. I think it's OK to add new
> things in a new way though (as long as there is a point of course).

After this patch, the tree will be mostly converted. ROM size
calculation for a few boards is still not factored out because it is
either unique or non-obvious. We need at least one other conversion
patch for the remaining boards and I'd appreciate help with that.

Can I use your Ack for an intermediary commit which has the include
files in src/config/, but with the old .lb name until someone writes up
a doc?



More information about the coreboot mailing list