[coreboot] [PATCH] flashrom - board enable - reconstruct table.
Luc Verhaegen
libv at skynet.be
Mon Apr 20 12:36:25 CEST 2009
On Mon, Apr 20, 2009 at 12:12:04PM +0200, Luc Verhaegen wrote:
> Flashrom: board_enables: reconstruct table.
>
> This patch restores the pciid based board matching table. It makes this
> table readable and hackable again, and the only disadvantage is that the
> right margin is way beyond the rather dogmatic 80. All 0x0000 pci ids have
> been string replaced by 0 to more easily spot missing ids, and extra
> comments have been added to explain how the various entries are used.
>
> Signed-Off-By: Luc Verhaegen <libv at skynet.be>
This is a recreation of a patch sent in earlier (back in january) to
undo commit r3861.
It was created by string replacements only, no data was manually moved
around, entries were just padded with spaces to adjust alignment. The
name of "Intel Desktop Board D201GLY" was shortened to "Intel D201GLY"
to keep the lines from becoming even longer. All 0x0000 pci-ids were
string replaced to 0. All entries are nicely aligned now, with a comment
at the top of the table to further ease understanding of this table.
Comments were added to further explain the use of the entries of this
table.
A lot of very recent motherboards seem to lack doubled up ids, or card
ids. Maybe the authors of these lines should be contacted and asked to
provide a bit more information to enable autodetection. It might also
be a good idea to require dual pciids for every board to further force
people to put some tought into the ids.
Luc Verhaegen.
More information about the coreboot
mailing list