[coreboot] [PATCH] Factor out ROM size calculation from Config.lb

Myles Watson mylesgw at gmail.com
Sat Apr 18 01:14:54 CEST 2009

On Fri, Apr 17, 2009 at 3:50 PM, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:
> On 17.04.2009 23:46, ron minnich wrote:
>> impressive.
> Thanks.
>> Did abuild work out ok?
> Yes, I even wrote that in the changelog, but it may have been drowned by
> the diffstat.
>> For a change of this magnitude, although I am absolutely certain it
>> works, maybe verification from two people on hardware would be a good
>> idea.
> Absolutely agreed. I'll wait with committing until someone has tested
> this. I just hope I don't have to wait for two tests on each board. One
> board should be sufficient, as the patches for each board are identical
> (if you ignore comments and whitespace).

I would think it would be sufficient to show that the coreboot.map
files are the same for the images produced.  To be an effective boot
test I think you'd have to boot into all three images, which will be
harder for people to want to do.


More information about the coreboot mailing list