[coreboot] [PATCH] Clean up $CC calls in Config.lb
Peter Stuge
peter at stuge.se
Mon Apr 13 06:20:01 CEST 2009
Peter Stuge wrote:
> Carl-Daniel Hailfinger wrote:
> > The following targets are broken by this patch
> ..
> > pcengines/alix1c
>
> I can build again with this patch applied.
With THIS patch.
//Peter
-------------- next part --------------
v2: Use return in alix1c cache_as_ram_main() like for several other LX boards.
Signed-off-by: Peter Stuge <peter at stuge.se>
Index: src/mainboard/pcengines/alix1c/cache_as_ram_auto.c
===================================================================
--- src/mainboard/pcengines/alix1c/cache_as_ram_auto.c (revision 4097)
+++ src/mainboard/pcengines/alix1c/cache_as_ram_auto.c (working copy)
@@ -202,9 +202,11 @@
__asm__("wbinvd\n");
print_err("Past wbinvd\n");
- /* We are finding the return does not work on this board. Explicitly
- * call the label that is after the call to us. This is gross, but
- * sometimes at this level it is the only way out.
+ /* r4097 shows that it is probably not a good idea to call
+ * done_cache_as_ram_main() here instead of return.
+ *
+ * Looking at a few other GeodeLX boards reveals that return does in
+ * fact seem to work. Let's try that again.
*/
- done_cache_as_ram_main();
+ return;
}
More information about the coreboot
mailing list